-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tabulator.ipynb to dynamically show correct version number of Tabulator #7053
Conversation
Doc says Tabulator 5.5 is used, but Tabulator.py shows 6.2.1 is used. Changed version number in doc to 6.2.1 . https://github.com/holoviz/panel/blob/main/panel%2Fmodels%2Ftabulator.py#L19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7053 +/- ##
==========================================
+ Coverage 81.76% 81.80% +0.03%
==========================================
Files 326 326
Lines 48315 48394 +79
==========================================
+ Hits 39505 39588 +83
+ Misses 8810 8806 -4 ☔ View full report in Codecov by Sentry. |
Let's try automating this like done in #5243 |
Yes that would be great! Was going through my head when I made the PR. Didn't know that was possible. Should this PR still go through in the mean time? I would say yes, as it corrects the info and creates a window to apply automation. I don't think I will be able to apply the PR you mention to automate it, as I am not familiar with that code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I will be able to apply the PR you mention to automate it, as I am not familiar with that code.
It is not hard to do! You just need to change the placeholder and update the conf.py file with the following:
version_replace = {
... # Other versions
"{{TABULATOR_VERSION}}": "6.2.1",
}
Ok added it to conf.py |
Adopted code suggestion by @hoxbro. Separately added version number to conf.py as stated Co-authored-by: Simon Høxbro Hansen <[email protected]>
Hm the line below causes the tests to fail with exit code 1. When I comment it out, tests are successful. @hoxbro , should it be: from panel.io.models.tabulator instead? from panel.models.tabulator import TABULATOR_VERSION |
Please combine this and #7062, and let us take it from there. You can confirm the import is correct with |
Guess I'll just merge both. |
Thank you. I was unable to combine the 2 PR's into one. |
Note: Is conf.py updated automatically / manually with the latest version? Should we do the same in other docs like for Perspective etc., so that correct library versions are always automatically shown in the various docs? |
+1 on showing version number in docs for components where it is relevant to study documents of js library to be able to use. |
Which other docs would this apply to? Perspective |
|
…sion numbers can be referred to dynamically in various docs See below PRwhere this was implemented for Tabulator doc. holoviz#7053
Doc says Tabulator 5.5 is used, but Tabulator.py shows 6.2.1 is used.
Changed version number in doc to 6.2.1 .
https://github.com/holoviz/panel/blob/main/panel%2Fmodels%2Ftabulator.py#L19