Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator sorters are correctly synced #7036

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

philippjfr
Copy link
Member

Fixes #3657

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (54ee768) to head (c6a1e1a).
Report is 1 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7036      +/-   ##
==========================================
+ Coverage   82.24%   82.25%   +0.01%     
==========================================
  Files         326      326              
  Lines       48271    48280       +9     
==========================================
+ Hits        39701    39715      +14     
+ Misses       8570     8565       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit a6f1503 into main Jul 29, 2024
15 checks passed
@philippjfr philippjfr deleted the tabulator_sort_reverse branch July 29, 2024 10:31
philippjfr added a commit that referenced this pull request Jul 29, 2024
* Ensure Tabulator sorters are correctly synced

* Add test

* Make other test more robust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: setting multiple sorters on init leads to an inconsistent state
1 participant