Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pyscript and pyodide #7016

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Update Pyscript and pyodide #7016

merged 7 commits into from
Aug 1, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jul 26, 2024

I would like to bring Pyscript up to date.

I have tested manually that the updates works.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (66625db) to head (ff16841).
Report is 15 commits behind head on main.

Files Patch % Lines
panel/io/pyodide.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7016      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.01%     
==========================================
  Files         326      326              
  Lines       48233    48315      +82     
==========================================
+ Hits        39658    39723      +65     
- Misses       8575     8592      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

UI tests fail on windows. I don't believe its related.

I don't plan to do more here.

@MarcSkovMadsen MarcSkovMadsen added this to the next milestone Jul 26, 2024
@MarcSkovMadsen MarcSkovMadsen changed the title Update Pyodide/ Pyscript Update Pyscript Jul 26, 2024
@philippjfr
Copy link
Member

Great, in the other PR I also restored the UI tests.

@MarcSkovMadsen
Copy link
Collaborator Author

Should this be merged then?

panel/io/convert.py Outdated Show resolved Hide resolved
@WebReflection
Copy link

if you "wait for it" we should release today with latest/greatest from both PyScript stack and Pyodide.

/cc @ntoll

@philippjfr
Copy link
Member

if you "wait for it" we should release today with latest/greatest from both PyScript stack and Pyodide.

Absolutely happy to wait, I really just wanted to get our test suite to validate it's all working.

@WebReflection
Copy link

WebReflection commented Aug 1, 2024

@philippjfr you can stop waiting https://github.com/pyscript/pyscript/releases/tag/2024.8.1 2024.8.1 it is, let us know if there are issues with it, thanks.

@philippjfr
Copy link
Member

Thanks everybody, tests are passing.

@philippjfr philippjfr merged commit 0d13915 into main Aug 1, 2024
15 checks passed
@philippjfr philippjfr deleted the update/pyodide-pyscript branch August 1, 2024 11:54
@philippjfr philippjfr modified the milestones: next, v1.5.0 Aug 2, 2024
@philippjfr philippjfr changed the title Update Pyscript Update Pyscript and pyodide Aug 2, 2024
@philippjfr
Copy link
Member

Also fixed #7016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants