-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TimePicker from Bokeh #7013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7013 +/- ##
==========================================
+ Coverage 82.17% 82.18% +0.01%
==========================================
Files 328 330 +2
Lines 49206 49268 +62
==========================================
+ Hits 40434 40493 +59
- Misses 8772 8775 +3 ☔ View full report in Codecov by Sentry. |
ahuang11
commented
Aug 5, 2024
hoxbro
reviewed
Aug 6, 2024
Okay I think it's ready import panel as pn
import datetime
pn.extension()
def change(event):
time_picker.value = datetime.time(hour=4, minute=8)
def print_picker(value):
print(value)
time_picker = pn.widgets.TimePicker(value=datetime.time(hour=18, minute=8), format="H:i")
pn.bind(print_picker, time_picker, watch=True)
button = pn.widgets.Button(name='Change Time', on_click=change)
pn.Row(time_picker, button).servable() Screen.Recording.2024-08-06.at.2.34.43.PM.mov |
Maybe worth adding a test for a different timezone: microsoft/playwright#26996 |
philippjfr
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TimePicker
The times mismatch due to timezone:
bokeh/bokeh#13768