Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: guard against user being removed #6908

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Auth: guard against user being removed #6908

merged 4 commits into from
Jun 12, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jun 10, 2024

A user reported sometimes getting a KeyError at line 1008 in auth.py.

@maximlt maximlt requested a review from philippjfr June 10, 2024 09:50
panel/auth.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (681ddc9) to head (0d6440f).
Report is 4 commits behind head on main.

Files Patch % Lines
panel/auth.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6908       +/-   ##
===========================================
+ Coverage   38.42%   81.54%   +43.12%     
===========================================
  Files         308      319       +11     
  Lines       45062    46915     +1853     
===========================================
+ Hits        17315    38259    +20944     
+ Misses      27747     8656    -19091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/auth.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit d7adb40 into main Jun 12, 2024
2 of 3 checks passed
@philippjfr philippjfr deleted the fix_oauth_keyerror branch June 12, 2024 08:58
maximlt added a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants