Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restore unmodified parameters in config.set #6772

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 22, 2024

Fix for issue described in #6766

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (cdcd074) to head (9d332c1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6772       +/-   ##
===========================================
+ Coverage   22.10%   70.38%   +48.28%     
===========================================
  Files         314      306        -8     
  Lines       46326    46197      -129     
===========================================
+ Hits        10240    32518    +22278     
+ Misses      36086    13679    -22407     
Flag Coverage Δ
unitexamples-tests 70.38% <100.00%> (+48.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c70aea8 into main Apr 22, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the config_set_restore branch April 22, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant