Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_allclose in test_svg_native_size #6635

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Apr 1, 2024

This makes test_svg_native_size robust by using assert_allclose for the float check.

When I run doit test_ui locally I see 4 fails:

FAILED panel/tests/ui/pane/test_image.py::test_svg_native_size[False] - assert 507.2109375 == 507.203125
FAILED panel/tests/ui/pane/test_image.py::test_svg_native_size[True] - assert 507.2109375 == 507.203125
FAILED panel/tests/ui/io/test_jupyterlite.py::test_jupyterlite_execution - playwright._impl._errors.TimeoutError: Timeout 20000ms exceeded.
FAILED panel/tests/ui/widgets/test_tabulator.py::test_tabulator_patch_no_height_resize - TimeoutError: wait_until timed out in 5000 milliseconds

The other two I can run like this:

pytest -v panel/tests/ui/io/test_jupyterlite.py --ui
pytest -v panel/tests/ui/widgets/test_tabulator.py --ui

and see that this is the problem:

OSError: [Errno 24] Too many open files

But I'm not sure why Panel opens so many files or how to fix this.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (385617b) to head (389cd48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6635   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         313      313           
  Lines       46132    46133    +1     
=======================================
+ Hits        38236    38237    +1     
  Misses       7896     7896           
Flag Coverage Δ
ui-tests 40.00% <100.00%> (+<0.01%) ⬆️
unitexamples-tests 71.17% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

But I'm not sure why Panel opens so many files or how to fix this.

Unclear to me too, suspect it must be sockets not files.

@philippjfr
Copy link
Member

Will merge, failing tests are fixed separately.

@philippjfr philippjfr merged commit 2b2be20 into holoviz:main Apr 2, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants