Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Perspective loads in notebooks #6626

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

philippjfr
Copy link
Member

Small oversight that led to Perspective not loading in notebooks (and notebook exports, which includes the docs).

Fixes #6612

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.94%. Comparing base (3079c49) to head (fbd3a62).

Files Patch % Lines
panel/models/perspective.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6626      +/-   ##
==========================================
- Coverage   82.95%   82.94%   -0.02%     
==========================================
  Files         313      313              
  Lines       46090    46092       +2     
==========================================
- Hits        38234    38229       -5     
- Misses       7856     7863       +7     
Flag Coverage Δ
ui-tests 40.02% <0.00%> (-0.01%) ⬇️
unitexamples-tests 71.22% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 9ce43c3 into main Apr 1, 2024
15 checks passed
@philippjfr philippjfr deleted the perspective_nb_render branch April 1, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perspective not rendering in reference guide
1 participant