Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no events are dispatched before the websocket is open #6528

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6521

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.11%. Comparing base (56e3103) to head (a224fb6).

❗ Current head a224fb6 differs from pull request most recent head 2333b9d. Consider uploading reports for the commit 2333b9d to get more accurate results

Files Patch % Lines
panel/chat/feed.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6528       +/-   ##
===========================================
- Coverage   81.91%   40.11%   -41.81%     
===========================================
  Files         313      313               
  Lines       45926    45909       -17     
===========================================
- Hits        37622    18416    -19206     
- Misses       8304    27493    +19189     
Flag Coverage Δ
ui-tests 40.11% <80.00%> (+2.82%) ⬆️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/chat/feed.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 18c0ac1 into main Mar 19, 2024
13 of 14 checks passed
@philippjfr philippjfr deleted the dispatch_before_load branch March 19, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_pending_writes should be non-None when ChatInterface.send with callback is called before served
1 participant