Use pn.Feed internally for ChatFeed #6296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6296 +/- ##
=======================================
Coverage 82.04% 82.05%
=======================================
Files 310 310
Lines 45935 45955 +20
=======================================
+ Hits 37688 37708 +20
Misses 8247 8247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| css_classes=["chat-feed-log"], | ||
| stylesheets=self._stylesheets, | ||
| **linked_params | ||
| ) | ||
| self._chat_log.height = None |
There was a problem hiding this comment.
Why is this needed? Should height be removed from linked_params?
There was a problem hiding this comment.
pn.Feed sets a fixed height if height is not explicitly set; if not, the local scrollbar never appears and thus no buffering is allowed.
Maybe it will be alleviated with this: #6266
There was a problem hiding this comment.
Okay, if I remove the fixed height from pn.Feed, no need to set ChatFeed._chat_log.height to None
Screen.Recording.2024-02-05.at.11.45.07.AM.mov
But Feed scroll bar is useless by the global scroll bar
Screen.Recording.2024-02-05.at.11.44.30.AM.mov
Replaces Column with Feed; works decently after fixing some bugs in the Feed branch.
Screen.Recording.2024-02-02.at.11.57.05.AM.mov