Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch HoloViews client comm to ensure server comm is initialized #6234

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

philippjfr
Copy link
Member

HoloViews has it's own code to initialize Jupyter comms here: https://github.com/holoviz/holoviews/blob/main/holoviews/plotting/renderer.py#L408

Sadly this means that the recent changes in #6229 to have the client Comm be responsible to initialize the server comm does not work for HoloViews. For now we therefore have to manually patch the client comm created by HoloViews with the required on_open callback. I will separately open a PR in HoloViews to add the on_open handler properly.

@philippjfr
Copy link
Member Author

Here's the PR adding the on_open handler in HoloViews: holoviz/holoviews#6076

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3a3b1be) 84.17% compared to head (d523d7c) 22.29%.
Report is 4 commits behind head on main.

Files Patch % Lines
panel/io/notebook.py 23.52% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6234       +/-   ##
===========================================
- Coverage   84.17%   22.29%   -61.88%     
===========================================
  Files         301      301               
  Lines       45099    45118       +19     
===========================================
- Hits        37963    10061    -27902     
- Misses       7136    35057    +27921     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 22.29% <23.52%> (-49.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 00a45d7 into main Jan 18, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the notebook_hv_patch branch January 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant