-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vtk various enhancements #606
Conversation
d4f42b5
to
74b7403
Compare
Cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very useful! I couldn't see anything in the source code about enabling or disabling this feature, and it seems like not all users will want to have it. Can you explain how to control its presence?
Hello for the moment nothing control it that's why I labeled it WIP. |
In that case just set the parameter controlling it to |
This PR enable culling possibilities: cf pyvista/pyvista#292 |
solve : pyvista/pyvista#300 |
We can control the display of the orientation widget now and control of key binding is re-eanabled @banesullivan I ping you to let you know some imporvements of the vtk viewer on our side |
I changed the way I create colorbar to have a more flexible layout https://xavartley.github.io/panel/vtk_examples/vtkEnhancement.html |
Amazing work, @xavArtley! |
95a121d
to
b595405
Compare
panel/links.py
Outdated
@@ -141,6 +141,11 @@ class GenericLink(Link): | |||
A dictionary mapping between source specification to target | |||
specification.""") | |||
|
|||
args = param.Dict(default={}, doc=""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Reenable vtk keyboard binding but only when mouse is over vtk pan
…ameter enable_key_bindings
4b3f5e7
to
8ac4125
Compare
This PR begin to be consequent |
536327f
to
daf4f37
Compare
daf4f37
to
b6c135b
Compare
Thanks so much for this work. I've mostly reviewed the documentation and made some suggestions. |
5e84d12
to
e158f0a
Compare
Update examples/reference/panes/VTK.ipynb Co-Authored-By: Philipp Rudiger <[email protected]>
81ca3ef
to
efa749c
Compare
Thanks for the fixes. The Python2 test failures are unrelated so I'll merge and fix them indepedently. |
@xavArtley, did these changes not make it onto version 0.6.4? I'm having trouble making these plots and still having trouble with needing to turn off |
Hello, the changes are not in 0.6. I think it will be in 0.7.
Le jeu. 17 oct. 2019 à 03:20, Bane Sullivan <[email protected]> a
écrit :
… serialization_policy (define when the serialization of the scene
happened): in pyvista no need to set auto_close to false anymore since the
new default behavior is to serialize the scene when the panel is created
and not displayed pyvista/pyvista#364
<pyvista/pyvista#364>
@xavArtley <https://github.com/xavArtley>, did these changes not make it
onto version 0.6.4? I'm having trouble making these plots and still having
trouble with needing to turn off auto_close
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#606>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENMGS6AR5RJEVNVDE5OLSDQO64UJANCNFSM4INYD5UQ>
.
|
Ah okay, thanks! I saw this was merged to master before 0.6.4 was released and thought something was weird. I look forward to 0.7! |
This PR corrects several bugs and add new fonctionnalities.
Bug fixes:
New:
serialization_policy
(define when the serialization of the scene happened): in pyvista no need to setauto_close
tofalse
anymore since the new default behavior is to serialize the scene when the panel is created and not displayed Interactive canvas within Jupyter Notebooks pyvista/pyvista#364orientation_widget: widget in the 3D view showing the orientation of the scene. Can be clicked to rotate along orthographic views (display is controled with orientation_widget=True|False)
possibility to display colorbars of the objects renderer in the scene (added in doc):
VTKVolume panel: The VTK panel represent objects by extracting the mesh surface of objects. However if we want to analyse the 3D volumetric data surface representation is not sufficient. Moreover to found some intersting information specific tools are needed like interactive color and opacity transfer function, gradient opactity functions... vtkjs propose very interesting application for this: https://kitware.github.io/vtk-js/examples/VolumeViewer/VolumeViewer.html?fileURL=https://data.kitware.com/api/v1/item/59e12e988d777f31ac6455c5/download. VTKVolume panel is just an helper to embed this application in a notebook and allow to work directly with vtkImageData or 3d numpy arrays. As the size of volume data can be very big a subsampling is implemented to limit the size of data transfered to javascript.
A new notebook for this panel was added
Issue not corrected:
Actor's property: LineWidth Kitware/vtk-js#673
- Opacity seems not be handle correctly (to investigate)Actualy it worksVTKVolume panel:
I have several improvements in mind but I think it should follow in an other PR