Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image caption #6003

Merged
merged 2 commits into from
Dec 10, 2023
Merged

add image caption #6003

merged 2 commits into from
Dec 10, 2023

Conversation

vaniisgh
Copy link
Contributor

@vaniisgh vaniisgh commented Dec 6, 2023

adds a caption kwarg as req in #5437 . Though it doesn't accept alignment from user yet.

@vaniisgh
Copy link
Contributor Author

vaniisgh commented Dec 6, 2023

would I be required to squash the commits ? @philippjfr

@hoxbro
Copy link
Member

hoxbro commented Dec 6, 2023

would I be required to squash the commits ?

No, this will be done automatically when we merge this PR into the main branch.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bb6aeb) 84.64% compared to head (b7773f6) 83.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6003      +/-   ##
==========================================
- Coverage   84.64%   83.09%   -1.56%     
==========================================
  Files         291      291              
  Lines       43546    43554       +8     
==========================================
- Hits        36859    36190     -669     
- Misses       6687     7364     +677     
Flag Coverage Δ
ui-tests 38.33% <37.50%> (-2.42%) ⬇️
unitexamples-tests 72.75% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Thank you so much! Happy to merge this without the caption alignment options. However it would be really great if you could add caption to the Parameters section in the following notebooks:

  • examples/reference/panes/Image.ipynb
  • examples/reference/panes/PNG.ipynb
  • examples/reference/panes/JPEG.ipynb
  • examples/reference/panes/SVG.ipynb

@philippjfr
Copy link
Member

Thanks so much for your contribution! I'll merge and add the docs separately.

@philippjfr philippjfr merged commit 9a2f39b into holoviz:main Dec 10, 2023
11 of 13 checks passed
philippjfr pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants