Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: make it clear pyviz_comms need to be installed next to Jupyter #5980

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 4, 2023

Addresses #5965

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6690bd3) 84.36% compared to head (7c0fc11) 84.38%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5980      +/-   ##
==========================================
+ Coverage   84.36%   84.38%   +0.01%     
==========================================
  Files         291      291              
  Lines       43452    43458       +6     
==========================================
+ Hits        36660    36670      +10     
+ Misses       6792     6788       -4     
Flag Coverage Δ
ui-tests 40.81% <ø> (+<0.01%) ⬆️
unitexamples-tests 72.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt
Copy link
Member Author

maximlt commented Dec 5, 2023

Thanks @MarcSkovMadsen, wording revised in 7c0fc11.

@philippjfr philippjfr merged commit 808bfc1 into main Dec 5, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the doc_pyviz_comms branch December 5, 2023 09:58
philippjfr pushed a commit that referenced this pull request Dec 12, 2023
…#5980)

* make it clear pyviz_comms need to be installed next to Jupyter

* clearer env install instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants