Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Tabulator Font Awesome CSS #5892

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 19, 2023

Closes #5759

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bfbf97) 84.09% compared to head (e487f18) 84.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5892   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         291      291           
  Lines       42653    42653           
=======================================
+ Hits        35868    35869    +1     
+ Misses       6785     6784    -1     
Flag Coverage Δ
ui-tests 40.81% <ø> (-0.01%) ⬇️
unitexamples-tests 72.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@philippjfr philippjfr merged commit 59fffcb into main Nov 19, 2023
13 checks passed
@philippjfr philippjfr deleted the enhancement/document-fontawesome branch November 19, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator icons are not showing up
2 participants