Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google OAuth default scopes #5823

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix Google OAuth default scopes #5823

merged 1 commit into from
Nov 6, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5815

@philippjfr philippjfr merged commit 2b1f88a into main Nov 6, 2023
1 of 2 checks passed
@philippjfr philippjfr deleted the fix_google_scopes branch November 6, 2023 13:28
@el-abcd
Copy link

el-abcd commented Nov 6, 2023

FWIW:

  • I looked at the code change and it LGTM.
  • I tried building / deploying from the "tip of main" and the oauth flow worked.

Details:

Then I had to fiddle around a bit to figure out how to "reset" so I would see the initial oauth login. I think the final piece was removing the id_token and access_token cookies.
Then the google oauth flow "worked as expected".

NOTE:

  • The tip of main DID have an issue for me (when run on docker+google cloud run), I see the "Panel Application" header and a blank sidebar, but no controls.
  • And I see a 404 error for a "panel.min.js" URL.
    • https:///static/extensions/panel/panel.min.js?v=05c64cb6a9476411f5c1be2445cb7e163b575262cf76c1c116348335d4f9686e"

But, that is clearly a separate issue, and maybe running against the "tip of main" isn't supported / a great idea?
And "tip of main" DID work for me locally (mac osx).

If useful I could file that as a separate issue.

BUT, this one looks like it is fixed! 👍

@petegordon
Copy link

I just want to say you guys are amazing! Thank you!

I hit this bug and was wrestling with it on panel 1.3.1 this morning thinking I should be using extra_oauth_params for the offline access. I upgraded panel and it fixed it no problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants