Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patching a table with pd.NaT values #5675

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix patching a table with pd.NaT values #5675

merged 1 commit into from
Oct 18, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 18, 2023

I got this error while trying to patch a table with a pd.NaT value.

        for name, patch in patches.items():
            for ind, value in patch:
                if isinstance(ind, (int, slice)):
>                   self[name][ind] = value
E                   TypeError: float() argument must be a string or a real number, not 'NaTType'

../../miniconda3/envs/panel310/lib/python3.10/site-packages/bokeh/core/property/wrappers.py:517: TypeError

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5675 (87f9e79) into main (055d680) will increase coverage by 8.60%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5675      +/-   ##
==========================================
+ Coverage   73.74%   82.34%   +8.60%     
==========================================
  Files         288      288              
  Lines       41967    41980      +13     
==========================================
+ Hits        30947    34570    +3623     
+ Misses      11020     7410    -3610     
Flag Coverage Δ
ui-tests 37.99% <23.07%> (?)
unitexamples-tests 73.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/tests/widgets/test_tables.py 99.80% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 88.99% <100.00%> (+1.32%) ⬆️

... and 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@philippjfr philippjfr merged commit fab0ea7 into main Oct 18, 2023
11 of 13 checks passed
@philippjfr philippjfr deleted the fix_patch_nat branch October 18, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants