Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streamlit Chat Migration Guide #5670

Merged
merged 14 commits into from
Oct 19, 2023
Merged

Add Streamlit Chat Migration Guide #5670

merged 14 commits into from
Oct 19, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 18, 2023

Supersedes #5642

@philippjfr
Copy link
Member Author

Not super convinced that we should add the ChatInput and ChatStatus examples.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5670 (c73f5e6) into main (cb6cfb5) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5670      +/-   ##
==========================================
- Coverage   84.10%   84.10%   -0.01%     
==========================================
  Files         288      288              
  Lines       41990    41984       -6     
==========================================
- Hits        35317    35309       -8     
- Misses       6673     6675       +2     
Flag Coverage Δ
ui-tests 40.79% <ø> (+<0.01%) ⬆️
unitexamples-tests 73.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarcSkovMadsen
Copy link
Collaborator

Questions

  • Should we provide a ChatInput component similar to Streamlits chat_input?
  • Should we provide a Status component similar to Streamlits status?

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 18, 2023

Not super convinced that we should add the ChatInput and ChatStatus examples.

I assume its because the components code are long and not for beginners?

But since we dont have those components in Panel today, how do we guide users wanting to migrate?

@ahuang11
Copy link
Contributor

ahuang11 commented Oct 18, 2023

If we have a ChatInput, I'd like it to be like the GitHub text box which lets users input both text and files by drag/drop.

But since we dont have those components in Panel today, how do we guide users wanting to migrate?

Isn't ChatInput equivalent to TextInput at the moment?

@philippjfr
Copy link
Member Author

We definitely want a full featured ChatInput in the long run.

But since we dont have those components in Panel today, how do we guide users wanting to migrate?

I think it's much better to either skip that or say that we are working on it than scaring the user with a huge wall of text.

@MarcSkovMadsen
Copy link
Collaborator

Isn't ChatInput equivalent to TextInput at the moment?

TextInput is What we have at the moment. But they are not equivalent.

  • the ChatInput combines a TextInput and Button.
  • the TextInput is cleared (on html side) when entered or submitted.

The ChatInput is easier to use when submitting multiple messages.

I think we carve out the advanced ChatInput you have implemented in the ChatInterface and Expose that @ahuang11

@ahuang11
Copy link
Contributor

Maybe in the future; I wouldn't want to hold up the Panel release any longer. Perhaps track it in a new issue?

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 18, 2023

Agree that we should not hold up the Panel release.

My suggestion would be to

  • make feature requests for ChatInput and Status. Phillip could comment in the request that he would like to accept a PR (if that is the case)

We could optionally

  • move the ChatInput and Status components to the panel-chat-examples as "components" examples.

What do you think?

@ahuang11
Copy link
Contributor

I like the idea of both.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 19, 2023

I've moved the ChatInput and Status components to holoviz-topics/panel-chat-examples#69. I will now document how to migrate 1) A basic chat example 2) a CallbackHandler example..

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 19, 2023

Assets

streamlit_callback_handler.mp4
panel_callback_handler.mp4

@MarcSkovMadsen
Copy link
Collaborator

This one is ready for review @philippjfr . I cannot request it from you as you opened the PR.

@MarcSkovMadsen MarcSkovMadsen mentioned this pull request Oct 19, 2023
37 tasks
@philippjfr philippjfr merged commit a59b084 into main Oct 19, 2023
1 of 2 checks passed
@philippjfr philippjfr deleted the chat_migration branch October 19, 2023 10:38
@MarcSkovMadsen
Copy link
Collaborator

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants