Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure notifications and browser_info are loaded in the extension #5657

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

philippjfr
Copy link
Member

Load notifications and browser_info even when HoloViews is in sys.modules. Previously Holoviews being available would always force nb_loaded to True meaning that browser_info and notifications would never get displayed.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5657 (8ba8dea) into main (af003b8) will increase coverage by 10.40%.
The diff coverage is 68.42%.

@@             Coverage Diff             @@
##             main    #5657       +/-   ##
===========================================
+ Coverage   73.70%   84.11%   +10.40%     
===========================================
  Files         288      288               
  Lines       41878    41879        +1     
===========================================
+ Hits        30866    35226     +4360     
+ Misses      11012     6653     -4359     
Flag Coverage Δ
ui-tests 40.82% <68.42%> (?)
unitexamples-tests 73.71% <10.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/io/convert.py 72.49% <ø> (+46.19%) ⬆️
panel/io/state.py 72.53% <ø> (+2.01%) ⬆️
panel/tests/ui/widgets/test_button.py 97.05% <100.00%> (+58.82%) ⬆️
panel/tests/ui/widgets/test_indicators.py 100.00% <100.00%> (+66.66%) ⬆️
panel/widgets/base.py 92.10% <50.00%> (ø)
panel/config.py 70.65% <16.66%> (+2.98%) ⬆️

... and 74 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 7e12f49 into main Oct 17, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the config_holoviews_bug branch October 17, 2023 15:33
@cdeil cdeil mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant