Add cache busting to server CSS resources #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5414 +/- ##
===========================================
- Coverage 82.69% 72.67% -10.03%
===========================================
Files 274 274
Lines 39897 39897
===========================================
- Hits 32994 28996 -3998
- Misses 6903 10901 +3998
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Why is this only an issue for css files? What about js, svg etc files? |
|
Bundled files are mirrored from npm and reflect the full path which generally contains a version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using server resources the URL for the CSS resources does not change between different versions of Panel. This means that it will always use the same cached resources even when a deployed application updates the Panel version it runs on. To address this we add a query parameter to CSS resources containing the current Panel.js version, which will ensure that on each version upgrade the cache is busted.