-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pytest-playwright install instructions to use conda #5380
Updating pytest-playwright install instructions to use conda #5380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
- Coverage 82.77% 82.68% -0.10%
==========================================
Files 274 274
Lines 39861 39935 +74
==========================================
+ Hits 32996 33021 +25
- Misses 6865 6914 +49
Flags with carried forward coverage won't be shown. Click here to find out more. see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you, and great initiative in getting the package on to conda! |
😞 I realise I created the conda package with the wrong name. It's supposed to be playwright-pytest, not pytest-playwright. Consider this a work in progress, I'll see if the Microsoft channel maintainers want to fix my mistake. |
I think pytest-playwright is correct - https://pypi.org/project/pytest-playwright/ |
Cheers, yeah @mxschmitt confirmed pytest-playwright as the package name is correct. Sorry when I noticed the repo and package names were reversed I thought I'd messed up. |
Now I look at the existing code closer I can see maybe you could conda install pytest-playright just by tweaking the doit line call:
I noticed later pytest-playwright is already a dependency in setup.py in the ui dependencies. If you added -c microsoft and -o ui to that call would that install those ui dependencies? I'm afraid I'm not familiar with pyctdev but can test that later if that was a better way to install it. |
We plan to overhaul the installation procedure soon, so I think we should keep the changes here on a documentation level. I still would like the option of |
Sorry for the slow follow up, let me know if this reads better to you @hoxbro |
Looks good, we're hopefully overhauling these docs again soon. |
With a lot of help from @mxschmitt I created a conda recipe for pytest-playwright which is now available on conda as of release 0.4.2 from the Microsoft channel (playwright-python already had a conda recipe).
As such I've updated the developer instructions to install pytest-playwright via conda instead of pip in the development environment (this should install playwright-python as a dependency).
I have tested I can still run the UI tests with these conda packages.