Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Tabulator row_contents as real children #5292

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

philippjfr
Copy link
Member

In the past it was very expensive to have deeply nested layouts so the children of a Tabulator were inserted as roots into the DOM. However with the bokeh 3.x layout engine this is no longer an issue so we now make them proper children which means signals will flow up and down the full tree of views, ensuring that layout and resize events correctly flow. Additionally we also trigger table resize events when a row is expanded.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5292 (e19743f) into main (e77da82) will decrease coverage by 57.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #5292       +/-   ##
===========================================
- Coverage   80.85%   23.75%   -57.10%     
===========================================
  Files         274      274               
  Lines       39701    39689       -12     
===========================================
- Hits        32100     9430    -22670     
- Misses       7601    30259    +22658     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 23.75% <ø> (-46.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 218 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 0c45a40 into main Jul 20, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the improve_tabulator_child_render branch July 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant