Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vizzu tooltip support #5258

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add Vizzu tooltip support #5258

merged 3 commits into from
Jul 18, 2023

Conversation

philippjfr
Copy link
Member

Implements #5255

@MarcSkovMadsen
Copy link
Collaborator

There vizzu docs have been updated and a few links in our reference notebook do not work any more. Let me document them below.

@MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen
Copy link
Collaborator

The links in the param docstrings are also invalid.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #5258 (be1b68a) into main (99ad77f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
- Coverage   83.80%   83.79%   -0.01%     
==========================================
  Files         274      274              
  Lines       39649    39651       +2     
==========================================
- Hits        33226    33225       -1     
- Misses       6423     6426       +3     
Flag Coverage Δ
ui-tests 40.57% <50.00%> (+<0.01%) ⬆️
unitexamples-tests 73.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/models/vizzu.py 88.00% <100.00%> (+0.50%) ⬆️
panel/pane/vizzu.py 55.46% <100.00%> (+0.37%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member Author

Thank you! I was also finally able to remove the forced re-render when the data is updated, which means animations now work when streaming, patching and updating data.

@philippjfr philippjfr merged commit 80559db into main Jul 18, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the vizzu_tooltip branch July 18, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants