Fix Tabulator expanded row rendering #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5253 +/- ##
==========================================
+ Coverage 82.53% 83.81% +1.27%
==========================================
Files 266 274 +8
Lines 39409 39606 +197
==========================================
+ Hits 32528 33194 +666
+ Misses 6881 6412 -469
Flags with carried forward coverage won't be shown. Click here to find out more. see 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
force-pushed
the
tabulator_render_row
branch
from
ba5868b
to
0af5524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering an expanded row and then scrolling until it is off-screen it will disappear and no event will cause the children inside the expanded row to be rendered once it is in view again. This is because we were registering the
rowFormatterevent rather than therowFormattercallback.