Clarify FloatInput value/value_thottled behavior in docs #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5249 +/- ##
==========================================
+ Coverage 82.53% 83.56% +1.02%
==========================================
Files 266 274 +8
Lines 39409 39606 +197
==========================================
+ Hits 32528 33098 +570
+ Misses 6881 6508 -373
Flags with carried forward coverage won't be shown. Click here to find out more. see 42 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Damn, I don't see how my docs update could've broken any of these tests... Do these intermittently fail often or is something wrong on the main branch? |
|
Don't worry, it is not related to your changes. The macos-latest unit tests also fail on main and the UI tests are flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd tweak this documentation that read a little funny to me when I was raising issue 5205. I think the word spinner threw me which I interpreted as busy spinner but maybe that meant spinbox.
I did some testing and found the value and value_throttled behaved seemingly identically in terms of updates. Also couldn't get the mouse wheel to change the value at all as the documentation implies it should.
Happy to have this PR rejected if I'm being too verbose or am writing too inconsistently with the other docs - I'm trying to slowly wrap my head around the preferred writing style and constraints.
Took the liberty of tweaking the .gitignore too as I was using PyCharm at the time and saw its config wasn't ignored while VS Code's was.