Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the editable attribute to pn.pane.Perspective #5211

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Add the editable attribute to pn.pane.Perspective #5211

merged 2 commits into from
Jul 5, 2023

Conversation

xiaoyang-sde
Copy link
Contributor

@xiaoyang-sde xiaoyang-sde commented Jul 5, 2023

fixes #5192

This pull request adds the editable attribute to pn.pane.Perspective, which allows the user to indicate whether items are editable. Otherwise, users are unable to control this behavior for the Perspective pane.

perspective

@xiaoyang-sde xiaoyang-sde marked this pull request as draft July 5, 2023 00:15
@xiaoyang-sde xiaoyang-sde marked this pull request as ready for review July 5, 2023 00:42
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #5211 (40ca5c6) into main (f7f9ea9) will decrease coverage by 1.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5211      +/-   ##
==========================================
- Coverage   83.82%   82.50%   -1.32%     
==========================================
  Files         274      274              
  Lines       39594    39583      -11     
==========================================
- Hits        33189    32659     -530     
- Misses       6405     6924     +519     
Flag Coverage Δ
ui-tests 39.51% <100.00%> (-1.03%) ⬇️
unitexamples-tests 72.49% <100.00%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/perspective.py 66.53% <100.00%> (+0.13%) ⬆️

... and 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 771ff43 into holoviz:main Jul 5, 2023
14 of 15 checks passed
@philippjfr
Copy link
Member

Thank you @xiaoyang-sde!

@xiaoyang-sde xiaoyang-sde deleted the 5192_perspective_editable branch July 5, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.pane.Perspective doesn't have the editable attribute
2 participants