Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix programmatic updates to Tabulator page #5187

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #4517
Fixes #5186

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #5187 (a3d0615) into main (209653e) will increase coverage by 9.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5187      +/-   ##
==========================================
+ Coverage   73.77%   83.56%   +9.78%     
==========================================
  Files         274      274              
  Lines       39575    39583       +8     
==========================================
+ Hits        29198    33076    +3878     
+ Misses      10377     6507    -3870     
Flag Coverage Δ
ui-tests 39.30% <100.00%> (?)
unitexamples-tests 73.77% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 99.32% <100.00%> (+89.89%) ⬆️

... and 53 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit eaf5853 into main Jun 29, 2023
14 of 15 checks passed
@philippjfr philippjfr deleted the tabulator_page_set_fix branch June 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant