[Bug Fix] Fix styling with filters in tabulator #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
philippjfr
reviewed
Jun 15, 2023
|
Thank you @enismaxim1, really appreciate the test as well. |
philippjfr
approved these changes
Jun 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #5110 +/- ##
==========================================
+ Coverage 82.93% 83.75% +0.82%
==========================================
Files 274 274
Lines 39133 39337 +204
==========================================
+ Hits 32455 32948 +493
+ Misses 6678 6389 -289
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Failing tests are just flaky, will work on making those more robust shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue identified in #5098, where Tabulator styling would not render after filtering in panel version 1.1.0.
Previously, there was a race condition causing the table to usually set styling before new data is processed into the table, meaning the table was rerendered without the requisite CSS. The solution is to reapply styling after the rerendering.
The PR also adds a test to check that styling is preserved after filtering, which passes due to the fix in this PR.