Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to clear enabled_dates in DatetimePicker #5089

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 11, 2023

Fixes #4949

Implementation is like the changes made upstream bokeh/bokeh#13194 to fix the problem.

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #5089 (eea450a) into main (60ba9c9) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   83.66%   83.04%   -0.62%     
==========================================
  Files         274      274              
  Lines       39133    39274     +141     
==========================================
- Hits        32739    32617     -122     
- Misses       6394     6657     +263     
Flag Coverage Δ
ui-tests 40.44% <100.00%> (-0.09%) ⬇️
unitexamples-tests 72.67% <0.00%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_input.py 99.47% <100.00%> (+<0.01%) ⬆️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could add a quick UI test?

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@philippjfr philippjfr merged commit 111242a into main Jun 14, 2023
13 of 15 checks passed
@philippjfr philippjfr deleted the clear_enabled_dates branch June 14, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to override enabled_dates by setting disabled_dates in DatePicker
2 participants