Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard is_file check when resolving resources on Windows #4985

Merged
merged 1 commit into from
May 31, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4982

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #4985 (500cb0f) into main (cf97774) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #4985      +/-   ##
==========================================
- Coverage   73.45%   73.44%   -0.01%     
==========================================
  Files         271      271              
  Lines       38289    38293       +4     
==========================================
+ Hits        28124    28125       +1     
- Misses      10165    10168       +3     
Flag Coverage Δ
unitexamples-tests 73.44% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/resources.py 87.23% <60.00%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 1aca525 into main May 31, 2023
9 of 14 checks passed
@philippjfr philippjfr deleted the guard_is_file_check branch May 31, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant