Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve equality checks when recursively updating pane #4934

Merged
merged 1 commit into from
May 25, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4932

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #4934 (f74d8b4) into main (96fb682) will decrease coverage by 10.07%.
The diff coverage is 10.00%.

@@             Coverage Diff             @@
##             main    #4934       +/-   ##
===========================================
- Coverage   83.44%   73.37%   -10.07%     
===========================================
  Files         270      270               
  Lines       38210    38215        +5     
===========================================
- Hits        31883    28039     -3844     
- Misses       6327    10176     +3849     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.37% <10.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/base.py 82.52% <10.00%> (-1.13%) ⬇️

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 1ac9749 into main May 25, 2023
10 of 14 checks passed
@philippjfr philippjfr deleted the equality_error branch May 25, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a Viewable with a Tabulator widget raises exception
1 participant