Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use basic auth with programmatic server #4926

Merged
merged 3 commits into from
May 24, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4906

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #4926 (87dd542) into main (95bdcb2) will increase coverage by 0.00%.
The diff coverage is 73.68%.

@@           Coverage Diff           @@
##             main    #4926   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files         270      270           
  Lines       38171    38187   +16     
=======================================
+ Hits        31849    31863   +14     
- Misses       6322     6324    +2     
Flag Coverage Δ
ui-tests 40.88% <52.63%> (-0.01%) ⬇️
unitexamples-tests 73.38% <31.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/server.py 76.83% <57.14%> (-0.26%) ⬇️
panel/auth.py 44.44% <77.77%> (+0.37%) ⬆️
panel/command/serve.py 40.92% <100.00%> (ø)
panel/config.py 77.04% <100.00%> (ø)
panel/io/state.py 73.39% <100.00%> (+0.37%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 80da5b4 into main May 24, 2023
10 of 14 checks passed
@philippjfr philippjfr deleted the basic_auth_server branch May 24, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Auth does not work when launching a Panel server dynamically
1 participant