Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VSCode does not apply white background #4923

Merged
merged 2 commits into from
May 24, 2023
Merged

Ensure VSCode does not apply white background #4923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af41b6a
Ensure VSCode does not apply white background
philippjfr May 24, 2023
89108c3
Override parent container
philippjfr May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion panel/_templates/jupyter.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,13 @@
box-sizing: border-box;
font-family: var(--jp-ui-font-family);
font-size: var(--jp-ui-font-size1);
color: var(--jp-ui-font-color1);
color: var(--vscode-editor-foreground, var(--jp-ui-font-color1));
}

/* Override VSCode background color */
.cell-output-ipywidget-background:has(> .cell-output-ipywidget-background
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:has() pseudo selector is not available in Firefox yet. Given this change is related to vscode, then maybe this is not a concern.

> .lm-Widget
> *[data-root-id]),
.cell-output-ipywidget-background:has(> .lm-Widget > *[data-root-id]) {
background-color: transparent !important;
}