Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure BasicAuth renders logo correctly #4900

Merged
merged 1 commit into from
May 19, 2023
Merged

Ensure BasicAuth renders logo correctly #4900

merged 1 commit into from
May 19, 2023

Conversation

philippjfr
Copy link
Member

The path to the panel logo was incorrect.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #4900 (63e2db7) into main (57d5885) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4900      +/-   ##
==========================================
- Coverage   83.12%   82.70%   -0.43%     
==========================================
  Files         270      270              
  Lines       38147    38147              
==========================================
- Hits        31710    31549     -161     
- Misses       6437     6598     +161     
Flag Coverage Δ
ui-tests 40.87% <100.00%> (+1.33%) ⬆️
unitexamples-tests 72.20% <50.00%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/auth.py 44.06% <100.00%> (+6.99%) ⬆️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 0586bae into main May 19, 2023
@philippjfr philippjfr deleted the basic_auth_logo branch May 19, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant