Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FloatPanel can be loaded in classic notebook #4892

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

philippjfr
Copy link
Member

Add require.js definitions so jspanel can be loaded in classic notebook.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #4892 (e239c22) into main (1edc2fc) will decrease coverage by 10.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #4892       +/-   ##
===========================================
- Coverage   83.42%   73.36%   -10.06%     
===========================================
  Files         270      270               
  Lines       38137    38138        +1     
===========================================
- Hits        31814    27981     -3833     
- Misses       6323    10157     +3834     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.36% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/layout/float.py 94.59% <100.00%> (+0.15%) ⬆️

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit c597f60 into main May 19, 2023
10 of 14 checks passed
@philippjfr philippjfr deleted the jspanel_require branch May 19, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant