Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reveal.js based SlideTemplate #4798

Merged
merged 10 commits into from
May 8, 2023
Merged

Implement reveal.js based SlideTemplate #4798

merged 10 commits into from
May 8, 2023

Conversation

philippjfr
Copy link
Member

Working on a talk and decided that I no longer wanted to use RISE, so I decided to implement a slides template for Panel instead.

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #4798 (50acf8d) into main (0736250) will increase coverage by 12.53%.
The diff coverage is 97.56%.

@@             Coverage Diff             @@
##             main    #4798       +/-   ##
===========================================
+ Coverage   70.67%   83.21%   +12.53%     
===========================================
  Files         268      269        +1     
  Lines       37943    37972       +29     
===========================================
+ Hits        26818    31600     +4782     
+ Misses      11125     6372     -4753     
Flag Coverage Δ
ui-tests 39.72% <78.04%> (?)
unitexamples-tests 73.35% <97.56%> (+2.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/template/golden/__init__.py 86.36% <83.33%> (+19.69%) ⬆️
panel/template/__init__.py 100.00% <100.00%> (ø)
panel/template/base.py 78.52% <100.00%> (+0.13%) ⬆️
panel/template/bootstrap/__init__.py 100.00% <100.00%> (ø)
panel/template/fast/base.py 95.00% <100.00%> (ø)
panel/template/material/__init__.py 100.00% <100.00%> (ø)
panel/template/slides/__init__.py 100.00% <100.00%> (ø)
panel/template/vanilla/__init__.py 100.00% <100.00%> (+8.33%) ⬆️
panel/viewable.py 66.16% <100.00%> (+2.34%) ⬆️

... and 67 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member Author

Will merge and add docs later. Want to get a last RC out.

@philippjfr philippjfr merged commit b20975a into main May 8, 2023
11 of 14 checks passed
@philippjfr philippjfr deleted the slides_template branch May 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant