Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabulator editor and formatter on_change handlers #4781

Merged
merged 1 commit into from
May 5, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4780

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #4781 (6070d4b) into main (a9a6da0) will increase coverage by 10.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #4781       +/-   ##
===========================================
+ Coverage   73.17%   83.27%   +10.09%     
===========================================
  Files         268      268               
  Lines       37786    37789        +3     
===========================================
+ Hits        27651    31469     +3818     
+ Misses      10135     6320     -3815     
Flag Coverage Δ
ui-tests 40.72% <100.00%> (?)
unitexamples-tests 73.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/tables.py 88.99% <100.00%> (+1.19%) ⬆️

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 49c67f5 into main May 5, 2023
12 of 14 checks passed
@philippjfr philippjfr deleted the fix_on_change_tabulator branch May 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between Tabulator and param.set_param
1 participant