Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ipywidgets handling #4779

Merged
merged 2 commits into from
May 5, 2023
Merged

Improve ipywidgets handling #4779

merged 2 commits into from
May 5, 2023

Conversation

philippjfr
Copy link
Member

The new comm library install a DummyComm unless we apply the patches in panel.io.ipywidget, so we handle this case and override the comm. Separately we must ensure that panel.io.ipywidget is loaded before ipywidgets_bokeh.

Fixes #2435

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #4779 (2c02952) into main (a9a6da0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4779      +/-   ##
==========================================
- Coverage   73.17%   73.16%   -0.02%     
==========================================
  Files         268      268              
  Lines       37786    37786              
==========================================
- Hits        27651    27645       -6     
- Misses      10135    10141       +6     
Flag Coverage Δ
unitexamples-tests 73.16% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/ipywidget.py 0.00% <0.00%> (ø)
panel/pane/ipywidget.py 53.22% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3e4e53b into main May 5, 2023
12 of 14 checks passed
@philippjfr philippjfr deleted the ipywidget_error branch May 5, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of ipywidgets do not render when using the panel.react template
1 participant