Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors in JupyterLab preview to server logs #4773

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

philippjfr
Copy link
Member

Previously there was no way to see errors that occurred while executing an app. We now intercept all stderr output and log it so it shows up in the Jupyter server logs.

Fixes #3440

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #4773 (a76a79e) into main (d822dba) will decrease coverage by 10.12%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #4773       +/-   ##
===========================================
- Coverage   83.27%   73.16%   -10.12%     
===========================================
  Files         268      268               
  Lines       37748    37752        +4     
===========================================
- Hits        31436    27621     -3815     
- Misses       6312    10131     +3819     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.16% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 771d6a5 into main May 4, 2023
11 of 14 checks passed
@philippjfr philippjfr deleted the preview_logs branch May 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make debugging of Jupyter Panel Preview easier
1 participant