Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for ipywidgets>=8.0.5 #4766

Merged
merged 1 commit into from
May 3, 2023
Merged

Improved support for ipywidgets>=8.0.5 #4766

merged 1 commit into from
May 3, 2023

Conversation

philippjfr
Copy link
Member

In ipywidgets >= 8.0.5 a separate comm package handles the Comm creation. In a notebook context the create_comm method is monkey-patched and in a server context we simply create a comm directly in the _on_widget_constructed hook but when using pn.serve or when building our documentation there is no state.curdoc defined and therefore we cannot hook up the Comm correctly when the widget is created. Therefore we patch the comm package with create_comm hook that creates a DummyComm which is later replaced.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #4766 (b6b6434) into main (12e2810) will decrease coverage by 10.13%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #4766       +/-   ##
===========================================
- Coverage   83.29%   73.17%   -10.13%     
===========================================
  Files         268      268               
  Lines       37745    37753        +8     
===========================================
- Hits        31441    27626     -3815     
- Misses       6304    10127     +3823     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.17% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/ipywidget.py 0.00% <0.00%> (ø)

... and 55 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 4ee83f0 into main May 3, 2023
12 of 14 checks passed
@philippjfr philippjfr deleted the ipywidget_fixes branch May 3, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant