Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Background #4664

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Organize Background #4664

merged 5 commits into from
Apr 18, 2023

Conversation

droumis
Copy link
Member

@droumis droumis commented Apr 17, 2023

Organizing the background. Addresses some of #4611

background-org

@droumis droumis requested a review from philippjfr April 17, 2023 23:30
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #4664 (6f4801c) into main (8c3430a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4664   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         266      266           
  Lines       37418    37418           
=======================================
+ Hits        31143    31144    +1     
+ Misses       6275     6274    -1     
Flag Coverage Δ
ui-tests 39.67% <ø> (+0.01%) ⬆️
unitexamples-tests 73.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@droumis
Copy link
Member Author

droumis commented Apr 18, 2023

note, I'm using externally hosted images for the other library logos, as I don't think I have access to add to assets.holoviz.org

@droumis
Copy link
Member Author

droumis commented Apr 18, 2023

update.. now using HoloViz-hosted assets

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!!!

@philippjfr philippjfr merged commit ecd961b into main Apr 18, 2023
@philippjfr philippjfr deleted the background-org branch April 18, 2023 17:03
@droumis droumis self-assigned this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants