Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ace to CodeEditor #4627

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Rename Ace to CodeEditor #4627

merged 5 commits into from
Apr 11, 2023

Conversation

philippjfr
Copy link
Member

As discussed in #4460

@philippjfr philippjfr added the api Related to Panel's API label Apr 11, 2023
@philippjfr philippjfr added this to the v1.0.0 milestone Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4627 (1ccd0aa) into main (a5c0c1e) will decrease coverage by 9.88%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main    #4627      +/-   ##
==========================================
- Coverage   83.15%   73.27%   -9.88%     
==========================================
  Files         260      260              
  Lines       37151    37159       +8     
==========================================
- Hits        30894    27230    -3664     
- Misses       6257     9929    +3672     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.27% <94.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/config.py 67.28% <ø> (ø)
panel/tests/test_docs.py 35.00% <0.00%> (ø)
panel/tests/widgets/test_codeeditor.py 100.00% <100.00%> (ø)
panel/widgets/__init__.py 100.00% <100.00%> (ø)
panel/widgets/codeeditor.py 93.02% <100.00%> (ø)

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

panel/widgets/codeeditor.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to Panel's API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants