Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plot size handling #4522

Merged
merged 6 commits into from
Mar 12, 2023
Merged

Improve plot size handling #4522

merged 6 commits into from
Mar 12, 2023

Conversation

philippjfr
Copy link
Member

  • Improves size handling of Vega, Plotly and DeckGL
  • Ensure custom models are cleaned up correctly

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #4522 (f56a545) into main (64e8d7b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4522      +/-   ##
==========================================
+ Coverage   83.38%   83.40%   +0.02%     
==========================================
  Files         246      246              
  Lines       36270    36270              
==========================================
+ Hits        30242    30252      +10     
+ Misses       6028     6018      -10     
Flag Coverage Δ
ui-tests 39.22% <100.00%> (+0.01%) ⬆️
unitexamples-tests 73.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/test_reactive.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b2a4b3c into main Mar 12, 2023
@philippjfr philippjfr deleted the size_handling branch March 12, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant