Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of responsive layouts #4491

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Improve handling of responsive layouts #4491

merged 4 commits into from
Mar 2, 2023

Conversation

philippjfr
Copy link
Member

  • Improves the look and feel of Cards
  • Experiment with overflow-x option on non-root responsive layouts

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #4491 (a0911fa) into main (f4395e5) will decrease coverage by 46.72%.
The diff coverage is 36.36%.

❗ Current head a0911fa differs from pull request most recent head 5544f62. Consider uploading reports for the commit 5544f62 to get more accurate results

@@             Coverage Diff             @@
##             main    #4491       +/-   ##
===========================================
- Coverage   82.24%   35.52%   -46.72%     
===========================================
  Files         243      235        -8     
  Lines       35316    35119      -197     
===========================================
- Hits        29044    12476    -16568     
- Misses       6272    22643    +16371     
Flag Coverage Δ
ui-tests 35.52% <36.36%> (-0.29%) ⬇️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/layout/card.py 72.58% <ø> (-20.97%) ⬇️
panel/layout/base.py 47.93% <36.36%> (-44.36%) ⬇️
panel/__main__.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/katex.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/mathjax.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/perspective.py 0.00% <0.00%> (-100.00%) ⬇️
panel/pane/vtk/synchronizable_deserializer.py 0.00% <0.00%> (-97.59%) ⬇️
panel/models/ace.py 0.00% <0.00%> (-91.67%) ⬇️
panel/tests/widgets/test_input.py 8.86% <0.00%> (-91.14%) ⬇️
panel/tests/io/test_embed.py 8.58% <0.00%> (-90.86%) ⬇️
... and 173 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 62fe471 into main Mar 2, 2023
@philippjfr philippjfr deleted the layout_fixes branch March 2, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant