Fix dataframe pane layout issues #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4435 +/- ##
==========================================
+ Coverage 81.65% 81.77% +0.12%
==========================================
Files 238 238
Lines 34872 34872
==========================================
+ Hits 28474 28518 +44
+ Misses 6398 6354 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The failing test is I don't plan to do more before feedback. |
philippjfr
reviewed
Feb 11, 2023
added 2 commits
February 11, 2023 15:50
MarcSkovMadsen
commented
Feb 11, 2023
| @@ -36,6 +36,11 @@ table.panel-df { | |||
| } | |||
|
|
|||
| .panel-df tr:hover { | |||
| background: lightblue !important; | |||
| background: #e1f5fe !important; | |||
There was a problem hiding this comment.
This color is prettier (my preference) and aligned with Jupyter
There was a problem hiding this comment.
I was thinking about wheyher we should set max_rows and max_cols to some number to minimize the risk of crashing the notebook?
|
Will merge for now. I'm doing a full review later anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4426