Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cancelling and empty value edit events on Tabulator #4343

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

philippjfr
Copy link
Member

  • Adds validators on Numeric edit events
  • Ensures that cancelling edit event does not clear cell
  • Maps an empty cell numeric cell to NaN

Fixes #3774

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #4343 (34a392e) into main (56a64cb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4343      +/-   ##
==========================================
+ Coverage   82.77%   82.78%   +0.01%     
==========================================
  Files         240      240              
  Lines       34599    34631      +32     
==========================================
+ Hits        28639    28669      +30     
- Misses       5960     5962       +2     
Flag Coverage Δ
ui-tests 38.33% <100.00%> (+0.05%) ⬆️
unitexamples-tests 73.75% <9.37%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 99.11% <100.00%> (+0.11%) ⬆️
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️
panel/io/convert.py 71.77% <0.00%> (-0.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b8116ac into main Jan 27, 2023
@philippjfr philippjfr deleted the tabulator_edit_cancel_nan branch January 27, 2023 12:41
philippjfr added a commit that referenced this pull request Jan 27, 2023
* Handle cancelling and empty value edit eventson Tabulator

* Remove stray console.log

* Minor cleanup

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clear float columns in Tabulator
1 participant