Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure type annotation allows str and PathLike objects on pn.serve #4336

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #3649

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4336 (677e8e1) into main (47f231b) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #4336      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.01%     
==========================================
  Files         240      240              
  Lines       34558    34562       +4     
==========================================
  Hits        28598    28598              
- Misses       5960     5964       +4     
Flag Coverage Δ
ui-tests 38.29% <0.00%> (-0.02%) ⬇️
unitexamples-tests 73.78% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/server.py 74.95% <57.14%> (-0.19%) ⬇️
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.serve also accepts string filename
1 participant