Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures global notification object can be used inside notebook callbacks #4331

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4230

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4331 (7cc81f5) into main (47f231b) will decrease coverage by 44.76%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #4331       +/-   ##
===========================================
- Coverage   82.74%   37.99%   -44.76%     
===========================================
  Files         240      232        -8     
  Lines       34558    34358      -200     
===========================================
- Hits        28596    13054    -15542     
- Misses       5962    21304    +15342     
Flag Coverage Δ
ui-tests 37.99% <0.00%> (-0.31%) ⬇️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/state.py 35.93% <0.00%> (-34.71%) ⬇️
panel/__main__.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/katex.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/mathjax.py 0.00% <0.00%> (-100.00%) ⬇️
panel/models/perspective.py 0.00% <0.00%> (-100.00%) ⬇️
panel/pane/vtk/synchronizable_deserializer.py 0.00% <0.00%> (-97.59%) ⬇️
panel/models/ace.py 0.00% <0.00%> (-91.67%) ⬇️
panel/tests/widgets/test_input.py 8.86% <0.00%> (-91.14%) ⬇️
panel/tests/io/test_embed.py 8.58% <0.00%> (-90.86%) ⬇️
panel/models/terminal.py 0.00% <0.00%> (-90.63%) ⬇️
... and 168 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 0711480 into main Jan 26, 2023
@philippjfr philippjfr deleted the fix_notification_lookup_notebook branch January 26, 2023 18:45
philippjfr added a commit that referenced this pull request Jan 26, 2023
…cks (#4331)

* Ensures global notification object can be used inside notebook callbacks

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications do not work if called inside a function in notebook
1 participant