Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue reusing FileDownload model #4328

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Fix issue reusing FileDownload model #4328

merged 2 commits into from
Jan 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4321

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4328 (8257f96) into main (58adf02) will decrease coverage by 12.41%.
The diff coverage is 35.00%.

@@             Coverage Diff             @@
##             main    #4328       +/-   ##
===========================================
- Coverage   82.67%   70.26%   -12.41%     
===========================================
  Files         239      240        +1     
  Lines       34514    34554       +40     
===========================================
- Hits        28533    24279     -4254     
- Misses       5981    10275     +4294     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 70.26% <35.00%> (-3.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/misc.py 94.44% <ø> (ø)
panel/tests/ui/widgets/test_misc.py 33.33% <33.33%> (ø)
panel/models/widgets.py 100.00% <100.00%> (ø)
panel/pane/vtk/synchronizable_deserializer.py 0.00% <0.00%> (-97.59%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 9.59% <0.00%> (-89.40%) ⬇️
panel/tests/ui/widgets/test_input.py 11.34% <0.00%> (-88.13%) ⬇️
panel/tests/ui/layout/test_accordion.py 14.72% <0.00%> (-85.28%) ⬇️
panel/tests/ui/widgets/test_sliders.py 15.42% <0.00%> (-84.58%) ⬇️
panel/tests/ui/layout/test_card.py 18.01% <0.00%> (-81.99%) ⬇️
panel/tests/io/test_notebook.py 20.83% <0.00%> (-79.17%) ⬇️
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 63f283f into main Jan 26, 2023
@philippjfr philippjfr deleted the file_download_fix branch January 26, 2023 16:22
philippjfr added a commit that referenced this pull request Jan 26, 2023
* Fix issue reusing FileDownload model

* Skip test on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileDownload working incorrectly inside Tabs when dynamic=True
1 participant