Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix links especially markdown links in sidebar #4222

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #4221

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #4222 (b08f5cd) into master (e02a0f2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4222   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         235      235           
  Lines       34171    34171           
=======================================
+ Hits        28380    28381    +1     
+ Misses       5791     5790    -1     
Flag Coverage Δ
ui-tests 37.91% <ø> (+<0.01%) ⬆️
unitexamples-tests 74.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/base.py 87.91% <0.00%> (-0.84%) ⬇️
panel/io/state.py 70.68% <0.00%> (+0.17%) ⬆️
panel/tests/util.py 91.26% <0.00%> (+1.94%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Thanks, was about to make the same changes.

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review December 18, 2022 13:01
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@philippjfr philippjfr merged commit e4ddd01 into master Dec 18, 2022
@philippjfr philippjfr deleted the fix/markdown-links-in-sidebar branch December 18, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in the Fast template sidebar does not style correctly
2 participants